Gera container#104
Open
LordOfPhys wants to merge 6 commits intoarhangeldim:masterfrom
LordOfPhys:gera-container
Open
Gera container#104LordOfPhys wants to merge 6 commits intoarhangeldim:masterfrom LordOfPhys:gera-container
LordOfPhys wants to merge 6 commits intoarhangeldim:masterfrom
LordOfPhys:gera-container
Conversation
| if (objByClassName.containsKey(className)) { | ||
| return objByClassName.get(className); | ||
| } else { | ||
| return getById(beanClass.get(className).getId()); |
Collaborator
There was a problem hiding this comment.
здесь тест падает с NPE. нужна проверка на существование бина
| */ | ||
| public Object getById(String id) { | ||
| return null; | ||
| public boolean isDepend(String classN, Field[] declaredF) { |
Collaborator
There was a problem hiding this comment.
метод лучше сделать приватным. доступ к нему снаружи не нужен
| field.setAccessible(true); | ||
| if (prop.getType().equals(ValueType.VAL)) { | ||
| Object value = Integer.parseInt(prop.getValue()); | ||
| field.set(obj, value); |
Collaborator
There was a problem hiding this comment.
В задании указано, что значения полей в объекте выставлять через методы setValue()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.